Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update supported Node.js versions #309

Merged
merged 3 commits into from
Sep 15, 2023
Merged

chore: update supported Node.js versions #309

merged 3 commits into from
Sep 15, 2023

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Sep 11, 2023

BREAKING CHANGE: remove support for Node.js 16.x

tsconfig.json Outdated
"module": "commonjs",
"resolveJsonModule": true,
"skipLibCheck": true,
"strict": true,
"target": "ES2021"
"target": "ES2023"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think target works with ES2023 yet. You can try ES2022

Suggested change
"target": "ES2023"
"target": "ES2022"

Or you can use ESNext so that bump typescript will also bump the target.

@aduh95 aduh95 merged commit 787e24d into main Sep 15, 2023
7 checks passed
@aduh95 aduh95 deleted the bump-nodejs branch September 15, 2023 08:42
@davyus321311

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants